Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Scala.js module config docs #1938

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Improve Scala.js module config docs #1938

merged 4 commits into from
Jul 13, 2022

Conversation

carlosedp
Copy link
Contributor

Improve Scala.js module config docs adding test and dependency descriptions.

@carlosedp
Update Common_Project_Layouts.adoc
e9c0532 
Improve Scala.js module config docs adding test and dependency descriptions.
@carlosedp
Fix ivy dep. Add comment to jsEnvConfig.
272992f
@lefou lefou requested a review from lolgab July 11, 2022 22:19
@carlosedp
Copy link
Contributor Author

carlosedp commented Jul 12, 2022 •
edited
Loading

Dunno why it's failing CI while downloading Scala 2.13.8.
Now it's good.

@carlosedp carlosedp requested a review from lolgab July 12, 2022 16:02
lefou
lefou reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the additional information presented as text.

docs/antora/modules/ROOT/pages/Common_Project_Layouts.adoc Outdated Show resolved Hide resolved
docs/antora/modules/ROOT/pages/Common_Project_Layouts.adoc Outdated Show resolved Hide resolved
@carlosedp carlosedp requested a review from lefou July 13, 2022 12:51
@lefou lefou merged commit 2100d28 into com-lihaoyi:main Jul 13, 2022
@lefou lefou added this to the after 0.10.5 milestone Jul 13, 2022
@lefou
Copy link
Member

lefou commented Jul 13, 2022

Thank you!

@carlosedp carlosedp deleted the patch-1 branch July 13, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolgab lolgab Awaiting requested review from lolgab

@lefou lefou Awaiting requested review from lefou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.6
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosedp @lefou @lolgab